[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL

ganeshmurthy
GitHub user gberginc opened a pull request:

    https://github.com/apache/qpid-proton/pull/116

    PROTON-1532: Allow insecure mechanism in SASL

    This commit extends SASL with the additional allow_insecure_mechs allowing users to override the defailt (false) authentication and use the plain mechanism. It also extends the Connection class to expose user and password that is used by the plain mechanism.
   
    Finally, this patch modifies the connect method which now avoids the use of the plain method which is not defined on SASL. The code now more resembles the Python version.
   
    This addresses the issue reported in [PROTON-1532](https://issues.apache.org/jira/browse/PROTON-1532) where I was trying to connect to an ActiveMQ using plain username/password authentication. Previous code used method `plain` which does not exist.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gberginc/qpid-proton sasl_allow_insecure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
   
----
commit e218be1f128f1c7452ca19626577043c46e53651
Author: Gregor Berginc <[hidden email]>
Date:   2017-08-11T12:00:34Z

    PROTON-1532: Allow insecure mechanism in SASL
   
    This commit extends SASL with the additional allow_insecure_mechs allowing users to override the defailt (false) authentication and use the plain mechanism. It also extends the Connection class to expose user and password that is used by the plain mechanism.
   
    Finally, this patch modifies the connect method which now avoids the use of the plain method which is not defined on SASL. The code now more resembles the Python version.
   
    Signed-off-by: Gregor Berginc <[hidden email]>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL

ganeshmurthy
Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/116
 
    @alanconway you may want to take a look at this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL

ganeshmurthy
In reply to this post by ganeshmurthy
Github user alanconway commented on the issue:

    https://github.com/apache/qpid-proton/pull/116
 
    Already in progress. The patch is basically correct but I want to rework how initial-only configuration is passed to  use "connection options" passed to connect() rather than adding setters to the Connection, similar to the new C++ API. Will post for review shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...