Re: Review Request 59889: PROTON-1495: c epoll use strerror_r() instead of unsafe strerr()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 59889: PROTON-1495: c epoll use strerror_r() instead of unsafe strerr()

Alan Conway

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59889/
-----------------------------------------------------------

(Updated June 7, 2017, 5:47 p.m.)


Review request for qpid and Cliff Jansen.


Repository: qpid-proton-git


Description (updated)
-------

PROTON-1495: c epoll use gai_strerror for getaddrinfo errors.
Also use strerror_r instead of thread-unsafe strerror.


Diffs
-----

  proton-c/src/proactor/epoll.c b6d2bd0a6f1f74b80f74b2275989b38dbf4e8bf5
  proton-c/src/proactor/libuv.c a851c4e503682a84180b28a99daf6088971c6bd2
  proton-c/src/proactor/proactor-internal.c 3525c71aeb7fc6ed50433ab8b61ccb271ac68761
  proton-c/src/tests/proactor.c 19cc7f32b5694758cd31f39bb7c6de71e32904ea


Diff: https://reviews.apache.org/r/59889/diff/1/


Testing
-------


Thanks,

Alan Conway