Re: Review Request 61596: allow hostname to be set for sasl-init
> On Aug. 11, 2017, 5:46 p.m., Andrew Stitcher wrote:
> > This looks fine.
> > Can you just confirm that adding this extra field to the frame is still amqp 1.0 protocol compliant (I dont have time to check that today).
> Gordon Sim wrote:
> From spec:
> <type name="sasl-init" class="composite" source="list" provides="sasl-frame">
> <descriptor name="amqp:sasl-init:list" code="0x00000000:0x00000041"/>
> <field name="mechanism" type="symbol" mandatory="true"/>
> <field name="initial-response" type="binary"/>
> <field name="hostname" type="string"/>
> "This field can be used by AMQP proxies to determine the correct back-end service to connect the
> client to, and to determine the domain to validate the client’s credentials against."
I've also verified that it is written as a string as required. (Initially I had it coming as a symbol which qpidd warned about).