[jira] [Commented] (DISPATCH-786) Message annotations transmitted on wire incorrectly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (DISPATCH-786) Message annotations transmitted on wire incorrectly

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/DISPATCH-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044908#comment-16044908 ]

Kim van der Riet commented on DISPATCH-786:
-------------------------------------------

It would appear to be a Proton commit that is causing this. Bisecting Proton found the following:
{noformat}
864519ddca6c45a10ec01598b3ff3b33e5591561 is the first bad commit
commit 864519ddca6c45a10ec01598b3ff3b33e5591561
Author: Alan Conway <[hidden email]>
Date:   Wed May 24 13:03:11 2017 -0400

    PROTON-1288: c++ provide convenient access to message/filter maps
   
    proton::map type to wrap map values for message properties/annotations and source filters.
   
    Has the following features:
   
    - type safe template for the standard AMQP 'restricted map' types
    - simple get()/put() interface for simple check/set individual properties
    - converts directly to/from a proton::value efficient pass-through, no re-coding
    - converts directly to/from std:map, std::unordered_map etc.
    - encode/decode only as required
   
    Intended use: use proton::map directly for simple get()/put(), convert to a
    standard map or sequence type for more complex use (iteration, preserving
    encoded order etc.)

:040000 040000 313084240254a017ec97d9cfd8a037dcf885fd3b f7ffa39d1ccd0aab2734d288165e76bc652b3d7d M examples
:040000 040000 7a904d86e6a9f0dbc278b9ed661c3bb2acfd6064 a548bf51667347b01c1fa815b4a3947d9b800e1d M proton-c
{noformat}

> Message annotations transmitted on wire incorrectly
> ---------------------------------------------------
>
>                 Key: DISPATCH-786
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-786
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Kim van der Riet
>            Assignee: Alan Conway
>         Attachments: dispatch-jms.pcapng
>
>
> Using today's master of dispatch router, qpid-interop-test's JMS messages test hangs. A look at a capture of the wire during this test shows the following:
> 1. Once the message annotations section is sent, a fragment of the annotation just sent is repeated, which is not correctly interpreted on the wire by the receiver.
> 2. Dispatch then closes the connection with a "amqp:connection:framing-error" the client follows with a TCP RST. However, dispatch appears to then continue and sends a flow, disposition and heartbeats to the closed connection.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]