[jira] [Commented] (QPID-7817) [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (QPID-7817) [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/QPID-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051465#comment-16051465 ]

ASF subversion and git services commented on QPID-7817:
-------------------------------------------------------

Commit 9713e49a0b12fa4a544b2ff92222446fd74416e2 in qpid-broker-j's branch refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=9713e49 ]

 QPID-7817: [WebSocket] Fix defect in buffer handling


> [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7817
>                 URL: https://issues.apache.org/jira/browse/QPID-7817
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: qpid-java-broker-7.0.0
>
>
> Currently the Java Broker's AMQP web socket implementation does not uphold all the following:
> Advanced Message Queuing Protocol (AMQP) WebSocket Binding (WSB) Version 1.0 Committee Specification 01 2.4 Exchanging AMQP Frames
> bq. There is no mapping between an AMQP frame and a WebSocket message. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket messages. Conversely, a single WebSocket message MAY contain one or more AMQP frames. There is also no mapping between an AMQP frame and a WebSocket frame. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket frames. Conversely, a single WebSocket frame MAY contain one or more AMQP frames.
> The current implementation will fail if a websocket frame arrives containing a partial AMQP frame.  Furthermore since, QPID-7763, internally WebSocketProvider chunks the incoming bytes into QBBs.  If this chunking results in a frame overlapping a chunk boundary, processing will fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...